Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unity catalog import from write_deltalake #3630

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Dec 20, 2024

Closes: #3629

@jaychia jaychia requested a review from kevinzwang December 20, 2024 12:55
@github-actions github-actions bot added the fix label Dec 20, 2024
Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #3630 will not alter performance

Comparing jay/fix-unity-imports (edff341) with main (5d4db4f)

Summary

✅ 27 untouched benchmarks

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (5d4db4f) to head (edff341).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
daft/dataframe/dataframe.py 22.22% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3630      +/-   ##
==========================================
- Coverage   78.01%   77.90%   -0.12%     
==========================================
  Files         720      720              
  Lines       88726    88726              
==========================================
- Hits        69221    69123      -98     
- Misses      19505    19603      +98     
Files with missing lines Coverage Δ
daft/dataframe/dataframe.py 85.29% <22.22%> (ø)

... and 14 files with indirect coverage changes

daft/dataframe/dataframe.py Outdated Show resolved Hide resolved
daft/dataframe/dataframe.py Outdated Show resolved Hide resolved
Copy link
Contributor

@desmondcheongzx desmondcheongzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fast fix!

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinzwang
Copy link
Member

Merging this in

@kevinzwang kevinzwang merged commit eabd029 into main Dec 20, 2024
42 of 43 checks passed
@kevinzwang kevinzwang deleted the jay/fix-unity-imports branch December 20, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'unitycatalog
3 participants