Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add warning for native runner #3613

Merged
merged 1 commit into from
Dec 19, 2024
Merged

chore: add warning for native runner #3613

merged 1 commit into from
Dec 19, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Dec 19, 2024

No description provided.

@jaychia jaychia requested a review from colin-ho December 19, 2024 06:27
@github-actions github-actions bot added the chore label Dec 19, 2024
@jaychia jaychia enabled auto-merge (squash) December 19, 2024 06:35
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #3613 will improve performances by 62.63%

Comparing jay/warn-native (b88705e) with main (5e40837)

Summary

⚡ 2 improvements
✅ 25 untouched benchmarks

Benchmarks breakdown

Benchmark main jay/warn-native Change
test_count[1 Small File] 3.9 ms 3.3 ms +19.04%
test_iter_rows_first_row[100 Small Files] 332.8 ms 204.6 ms +62.63%

@jaychia jaychia merged commit 063de4d into main Dec 19, 2024
41 checks passed
@jaychia jaychia deleted the jay/warn-native branch December 19, 2024 06:48
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.81%. Comparing base (5e40837) to head (b88705e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3613   +/-   ##
=======================================
  Coverage   77.81%   77.81%           
=======================================
  Files         718      718           
  Lines       88249    88252    +3     
=======================================
+ Hits        68667    68674    +7     
+ Misses      19582    19578    -4     
Files with missing lines Coverage Δ
daft/context.py 87.65% <100.00%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants