-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add build step to run-cluster #3606
Conversation
CodSpeed Performance ReportMerging #3606 will degrade performances by 30.61%Comparing Summary
Benchmarks breakdown
|
Example of a successful run: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3606 +/- ##
=======================================
Coverage 77.80% 77.80%
=======================================
Files 718 718
Lines 88176 88247 +71
=======================================
+ Hits 68607 68664 +57
- Misses 19569 19583 +14 |
- if daft-version is specified, then build-commit is skipped and the empty string is used instead of `needs.build.outputs.wheel_url` - remember, the `wheel_url` will never be set due to the fact that the `build` job was never run - if the daft-version is *not* specified, then the `build` step *is* run and the `wheel_url` will properly be set
Example of a run that does not specify Example of a run that specifies only Example of a run that specifies only |
Overview
The
run-cluster
workflow now also builds the commit by calling thebuild-commit
workflow first.