-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: tpcds benchmarking #3597
ci: tpcds benchmarking #3597
Conversation
- this should only happen in the uv run scripts
CodSpeed Performance ReportMerging #3597 will improve performances by 42.54%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3597 +/- ##
==========================================
+ Coverage 77.85% 77.93% +0.07%
==========================================
Files 719 720 +1
Lines 88455 88480 +25
==========================================
+ Hits 68871 68960 +89
+ Misses 19584 19520 -64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic for checking if the wheel exists/triggering the workflow should not be in TPC-DS workflow.
It's re-usable for other jobs as well (I'd want to use it for my jobs). Likely belongs in the run-cluster workflow, or a wrapper of that which runs one after the other.
Closing in favour of #3619. |
Overview
This PR introduces a new script called
tpcds.py
which runs thebuild-commit
workflow (only if a pre-built wheel does not exist), and then runs therun-cluster
workflow on the built wheel.Note
The
build-commit.yaml
workflow has been changed to not perform any checking if python wheel exists; that logic has been moved into thetpcds.py
script.Usage
uv run tools/tpcds.py --ref $MY_BRANCH --force