Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow for level 2 of Ray tracing which records memory #3590

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Dec 17, 2024

No description provided.

@github-actions github-actions bot added the chore label Dec 17, 2024
Copy link

codspeed-hq bot commented Dec 17, 2024

CodSpeed Performance Report

Merging #3590 will improve performances by 11.97%

Comparing jay/track-ray-task-memory-usage (890fd6a) with main (4bb0413)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main jay/track-ray-task-memory-usage Change
test_count[1 Small File] 3.6 ms 3.2 ms +11.97%

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 25 lines in your changes missing coverage. Please review.

Project coverage is 77.85%. Comparing base (4bb0413) to head (890fd6a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
daft/runners/ray_tracing.py 16.66% 20 Missing ⚠️
src/common/daft-config/src/lib.rs 33.33% 4 Missing ⚠️
daft/runners/ray_metrics.py 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3590      +/-   ##
==========================================
- Coverage   77.86%   77.85%   -0.01%     
==========================================
  Files         719      719              
  Lines       88455    88487      +32     
==========================================
+ Hits        68872    68889      +17     
- Misses      19583    19598      +15     
Files with missing lines Coverage Δ
daft/context.py 87.19% <ø> (ø)
src/common/daft-config/src/python.rs 68.39% <100.00%> (ø)
daft/runners/ray_metrics.py 58.24% <87.50%> (+2.94%) ⬆️
src/common/daft-config/src/lib.rs 82.85% <33.33%> (-1.21%) ⬇️
daft/runners/ray_tracing.py 58.91% <16.66%> (-4.27%) ⬇️

... and 5 files with indirect coverage changes

@jaychia jaychia force-pushed the jay/track-ray-task-memory-usage branch from 3606795 to 890fd6a Compare December 18, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant