-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add url_download/url_upload as sql function #3575
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #3575 will improve performances by 48.63%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3575 +/- ##
==========================================
- Coverage 77.99% 77.96% -0.04%
==========================================
Files 720 721 +1
Lines 88794 88944 +150
==========================================
+ Hits 69252 69341 +89
- Misses 19542 19603 +61
|
cbeb3f9
to
655307a
Compare
@andrewgazelka could you help get this through? |
Would you please consider reviewing this PR? @andrewgazelka |
Hey sorry I missed the @ . I will look at now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR could benefit from some minor changes
LGTM CC @universalmind303 for sanity check as he has touched a lot of code in this area |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
Currently, download_url/upload_url only support DataFrame API, this PR adds download_url/upload_url to sql, which could be used for image processing demo.