Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connect): count returns the number of rows in the table #3552

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −1

fix(connect): `count` returns the number of rows in the table

fdc1830
Select commit
Loading
Failed to load commit list.
Draft

fix(connect): count returns the number of rows in the table #3552

fix(connect): `count` returns the number of rows in the table
fdc1830
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Dec 19, 2024 in 0s

Performance Regression: -62.04%

Summary

❌ 2 regressions
✅ 25 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andrew/connect-count Change
❌ test_count[1 Small File] 3.4 ms 3.9 ms -10.81%
❌ test_iter_rows_first_row[100 Small Files] 131.6 ms 346.8 ms -62.04%
View more details on CodSpeed HQ