Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] run cluster on commit #3461

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[FEAT] run cluster on commit #3461

merged 1 commit into from
Dec 2, 2024

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Dec 2, 2024

Overview

This PR extends the existing run-clusters workflow with the ability to run on any arbitrary daft-wheel that is given to it.

@github-actions github-actions bot added the enhancement New feature or request label Dec 2, 2024
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #3461 will degrade performances by 33.08%

Comparing feat/run-cluster-on-commit (709e2da) with main (b5f60e0)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/run-cluster-on-commit Change
test_count[1 Small File] 4.1 ms 3.4 ms +21.01%
test_iter_rows_first_row[100 Small Files] 298.1 ms 384.3 ms -22.44%
test_show[100 Small Files] 16.6 ms 24.8 ms -33.08%

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.49%. Comparing base (b5f60e0) to head (709e2da).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3461   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files         687      687           
  Lines       84483    84483           
=======================================
+ Hits        65471    65473    +2     
+ Misses      19012    19010    -2     

see 2 files with indirect coverage changes

@raunakab raunakab force-pushed the feat/run-cluster-on-commit branch from cf5ceaf to 5791f8b Compare December 2, 2024 16:43
@raunakab raunakab marked this pull request as ready for review December 2, 2024 16:43
@raunakab raunakab requested review from jaychia and colin-ho December 2, 2024 16:43
@raunakab raunakab force-pushed the feat/run-cluster-on-commit branch from 43e02e4 to 709e2da Compare December 2, 2024 18:29
.github/ci-scripts/templatize_ray_config.py Show resolved Hide resolved
.github/workflows/run-cluster.yaml Show resolved Hide resolved
.github/workflows/run-cluster.yaml Show resolved Hide resolved
@raunakab raunakab merged commit c9bfd91 into main Dec 2, 2024
44 of 45 checks passed
@raunakab raunakab deleted the feat/run-cluster-on-commit branch December 2, 2024 19:40
raunakab pushed a commit that referenced this pull request Dec 2, 2024
raunakab pushed a commit that referenced this pull request Dec 2, 2024
# Overview
Address leftover comments on
#3461.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants