Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split *all* Parquet ScanTasks by default #3454

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Perform split on all files

bba2bed
Select commit
Loading
Failed to load commit list.
Draft

feat: Split *all* Parquet ScanTasks by default #3454

Perform split on all files
bba2bed
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2024 in 1s

77.87% (+0.06%) compared to 063de4d

View this Pull Request on Codecov

77.87% (+0.06%) compared to 063de4d

Details

Codecov Report

Attention: Patch coverage is 89.97821% with 46 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (063de4d) to head (bba2bed).

Files with missing lines Patch % Lines
...scan_task_iters/split_parquet_files_by_rowgroup.rs 89.50% 19 Missing ⚠️
...n/src/scan_task_iters/retrieve_parquet_metadata.rs 92.35% 12 Missing ⚠️
...n/src/scan_task_iters/mark_scan_tasks_for_split.rs 87.93% 7 Missing ⚠️
src/common/daft-config/src/lib.rs 54.54% 5 Missing ⚠️
src/common/daft-config/src/python.rs 57.14% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3454      +/-   ##
==========================================
+ Coverage   77.80%   77.87%   +0.06%     
==========================================
  Files         718      721       +3     
  Lines       88250    88700     +450     
==========================================
+ Hits        68666    69072     +406     
- Misses      19584    19628      +44
Files with missing lines Coverage Δ
daft/context.py 87.65% <ø> (ø)
src/daft-scan/src/scan_task_iters.rs 97.33% <100.00%> (+0.43%) ⬆️
src/common/daft-config/src/python.rs 68.03% <57.14%> (-0.36%) ⬇️
src/common/daft-config/src/lib.rs 79.74% <54.54%> (-4.32%) ⬇️
...n/src/scan_task_iters/mark_scan_tasks_for_split.rs 87.93% <87.93%> (ø)
...n/src/scan_task_iters/retrieve_parquet_metadata.rs 92.35% <92.35%> (ø)
...scan_task_iters/split_parquet_files_by_rowgroup.rs 89.50% <89.50%> (ø)

... and 2 files with indirect coverage changes

View more details on Codecov