Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add missing list expression entries #3428

Merged

Conversation

desmondcheongzx
Copy link
Contributor

Add

Additionally, sorted the expressions in this subsection.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 25, 2024
Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #3428 will degrade performances by 42.48%

Comparing desmondcheongzx:add-missing-list-expr-docs (0bdff4e) with main (fa1d9d7)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main desmondcheongzx:add-missing-list-expr-docs Change
test_show[100 Small Files] 23.8 ms 41.3 ms -42.48%

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (8052de7) to head (0bdff4e).
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3428   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files         684      684           
  Lines       83627    83639   +12     
=======================================
+ Hits        64688    64700   +12     
  Misses      18939    18939           

see 8 files with indirect coverage changes

@kevinzwang
Copy link
Member

@jaychia is the PR doc publishing workflow working? I don't see how to view them.

@kevinzwang kevinzwang merged commit 2db1233 into Eventual-Inc:main Nov 27, 2024
41 of 42 checks passed
@desmondcheongzx desmondcheongzx deleted the add-missing-list-expr-docs branch November 27, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants