-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add cluster profiles #3426
Conversation
- makes more sense - this is a template file which will be dynamically string-replaced at runtime by the GHA
CodSpeed Performance ReportMerging #3426 will improve performances by 73.35%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3426 +/- ##
==========================================
- Coverage 77.35% 76.85% -0.51%
==========================================
Files 684 684
Lines 83639 85145 +1506
==========================================
+ Hits 64700 65435 +735
- Misses 18939 19710 +771 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but I would probably refactor to move to doing it in Python dictionaries instead of parametrizing a YAML string. Cleaner, less prone to bugs, and at some point easier to test too.
Overview
medium-x86
,debug_xs-x86
, etc.) that end-users can select fromAvailable Options
medium-x86
debug_xs-x86
I will plan on adding more in the future. For now, this should suffice.