Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add cluster profiles #3426

Merged
merged 10 commits into from
Dec 1, 2024
Merged

[FEAT] Add cluster profiles #3426

merged 10 commits into from
Dec 1, 2024

Conversation

raunakab
Copy link
Contributor

Overview

  • When running a job on a ray-cluster using GHA, we want to be able to configure the configuration of the cluster.
    • this is achieved via "cluster profiles"
    • essentially, this is a set number of configurations (e.g., medium-x86, debug_xs-x86, etc.) that end-users can select from
    • this will take care of all of the configurations without leaking the internals of the ray-configuration story

Available Options

  • medium-x86
  • debug_xs-x86

I will plan on adding more in the future. For now, this should suffice.

@github-actions github-actions bot added the enhancement New feature or request label Nov 25, 2024
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #3426 will improve performances by 73.35%

Comparing feat/cluster-profiles (cc5c5f5) with main (c012577)

Summary

⚡ 1 improvements
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/cluster-profiles Change
test_iter_rows_first_row[100 Small Files] 391.7 ms 225.9 ms +73.35%

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (c012577) to head (cc5c5f5).
Report is 26 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3426      +/-   ##
==========================================
- Coverage   77.35%   76.85%   -0.51%     
==========================================
  Files         684      684              
  Lines       83639    85145    +1506     
==========================================
+ Hits        64700    65435     +735     
- Misses      18939    19710     +771     

see 8 files with indirect coverage changes

@raunakab raunakab requested a review from jaychia November 26, 2024 18:12
@raunakab raunakab marked this pull request as ready for review November 26, 2024 18:12
Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but I would probably refactor to move to doing it in Python dictionaries instead of parametrizing a YAML string. Cleaner, less prone to bugs, and at some point easier to test too.

.github/assets/.template.yaml Show resolved Hide resolved
@raunakab raunakab merged commit b5f60e0 into main Dec 1, 2024
68 of 73 checks passed
@raunakab raunakab deleted the feat/cluster-profiles branch December 1, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants