Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add ability to run arbitrary command on a set working directory #3404

Merged
merged 22 commits into from
Nov 23, 2024

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Nov 23, 2024

Overview

  • this PR will add the ability to run some arbitrary command on the ray cluster that the workflow has booted up
  • the working directory can be specified (defaults to .github/assets)
  • the command can be specified (must be provided; furthermore, empty strings will result in a failure of the workflow)

@github-actions github-actions bot added the enhancement New feature or request label Nov 23, 2024
Copy link

codspeed-hq bot commented Nov 23, 2024

CodSpeed Performance Report

Merging #3404 will improve performances by 41.85%

Comparing feat/run-3 (de6c84d) with main (5dce4fb)

Summary

⚡ 2 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/run-3 Change
test_iter_rows_first_row[100 Small Files] 378.7 ms 266.9 ms +41.85%
test_show[100 Small Files] 29.8 ms 24.7 ms +20.62%

@raunakab raunakab requested a review from jaychia November 23, 2024 02:41
@raunakab raunakab marked this pull request as ready for review November 23, 2024 02:41
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (5dce4fb) to head (de6c84d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3404      +/-   ##
==========================================
- Coverage   77.35%   77.35%   -0.01%     
==========================================
  Files         684      684              
  Lines       83629    83629              
==========================================
- Hits        64694    64693       -1     
- Misses      18935    18936       +1     

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

.github/assets/simple.py Outdated Show resolved Hide resolved
@raunakab raunakab requested a review from jaychia November 23, 2024 18:02
@raunakab raunakab merged commit b6706d9 into main Nov 23, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants