-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add steps to spin up, submit job, and spin down ray clusters #3403
Conversation
CodSpeed Performance ReportMerging #3403 will degrade performances by 12.24%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3403 +/- ##
==========================================
- Coverage 77.35% 76.13% -1.22%
==========================================
Files 684 684
Lines 83627 85253 +1626
==========================================
+ Hits 64688 64911 +223
- Misses 18939 20342 +1403
|
- otherwise, it fills in nothing resulting in a syntax error
- will always run, even if the previous steps fail
- name: Setup connection to ray cluster | ||
run: | | ||
source .venv/bin/activate | ||
ray dashboard .github/assets/benchmarking_ray_config.yaml & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but might need to check if this background process will get correctly terminated when the workflow finishes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe one way to check is by running 2 subsequent jobs on the same machine.
If the background job is not killed after the first WF run terminates, then it will affect the second WF run when it tries to use port 8265.
Overview
Note
If any of the previous steps fail, the "tear-down" step (responsible for tearing down the ray cluster), will still always run. (The only way this tear-down step would not be run is if the workflow is manually cancelled).