Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add steps to spin up, submit job, and spin down ray clusters #3403

Merged
merged 15 commits into from
Nov 23, 2024

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Nov 23, 2024

Overview

  • new steps that:
    • spin up
    • submit job
    • spin down ray clusters

Note

If any of the previous steps fail, the "tear-down" step (responsible for tearing down the ray cluster), will still always run. (The only way this tear-down step would not be run is if the workflow is manually cancelled).

@github-actions github-actions bot added the enhancement New feature or request label Nov 23, 2024
Copy link

codspeed-hq bot commented Nov 23, 2024

CodSpeed Performance Report

Merging #3403 will degrade performances by 12.24%

Comparing feat/run-2 (1d1cc20) with main (31a7abc)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/run-2 Change
test_iter_rows_first_row[100 Small Files] 278.6 ms 317.5 ms -12.24%
test_show[100 Small Files] 23.8 ms 15.6 ms +52.72%

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.13%. Comparing base (5b36bd0) to head (1d1cc20).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3403      +/-   ##
==========================================
- Coverage   77.35%   76.13%   -1.22%     
==========================================
  Files         684      684              
  Lines       83627    85253    +1626     
==========================================
+ Hits        64688    64911     +223     
- Misses      18939    20342    +1403     

see 23 files with indirect coverage changes

---- 🚨 Try these New Features:

@raunakab raunakab requested a review from jaychia November 23, 2024 01:58
@raunakab raunakab marked this pull request as ready for review November 23, 2024 01:58
.github/assets/benchmarking_ray_config.yaml Outdated Show resolved Hide resolved
- name: Setup connection to ray cluster
run: |
source .venv/bin/activate
ray dashboard .github/assets/benchmarking_ray_config.yaml &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but might need to check if this background process will get correctly terminated when the workflow finishes.

Copy link
Contributor Author

@raunakab raunakab Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one way to check is by running 2 subsequent jobs on the same machine.

If the background job is not killed after the first WF run terminates, then it will affect the second WF run when it tries to use port 8265.

@raunakab raunakab enabled auto-merge (squash) November 23, 2024 02:13
@raunakab raunakab merged commit 5dce4fb into main Nov 23, 2024
41 of 42 checks passed
@raunakab raunakab deleted the feat/run-2 branch November 23, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants