Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Create new run workflow #3402

Merged
merged 1 commit into from
Nov 23, 2024
Merged

[FEAT] Create new run workflow #3402

merged 1 commit into from
Nov 23, 2024

Conversation

raunakab
Copy link
Contributor

Overview

  • create workflow to just minimally setup stuff on ray-cluster
  • not fully working yet :(

@raunakab raunakab marked this pull request as ready for review November 23, 2024 00:16
@raunakab raunakab requested a review from jaychia November 23, 2024 00:16
@github-actions github-actions bot added the enhancement New feature or request label Nov 23, 2024
@jaychia jaychia enabled auto-merge (squash) November 23, 2024 00:18
Copy link

codspeed-hq bot commented Nov 23, 2024

CodSpeed Performance Report

Merging #3402 will degrade performances by 55.74%

Comparing feat/run (370c04a) with main (68248a9)

Summary

❌ 2 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/run Change
test_iter_rows_first_row[100 Small Files] 236.3 ms 350.5 ms -32.57%
test_show[100 Small Files] 15.2 ms 34.2 ms -55.74%

@jaychia jaychia merged commit 5b36bd0 into main Nov 23, 2024
41 of 42 checks passed
@jaychia jaychia deleted the feat/run branch November 23, 2024 00:38
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.36%. Comparing base (68248a9) to head (370c04a).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3402   +/-   ##
=======================================
  Coverage   77.35%   77.36%           
=======================================
  Files         685      685           
  Lines       83644    83644           
=======================================
+ Hits        64705    64708    +3     
+ Misses      18939    18936    -3     

see 3 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants