Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Change IOConfig to be serialized into binary instead of JSON #3400

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

kevinzwang
Copy link
Member

No description provided.

Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #3400 will degrade performances by 43.76%

Comparing kevin/io-config-bin-serde (627881b) with main (60ae62f)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kevin/io-config-bin-serde Change
test_iter_rows_first_row[100 Small Files] 388.4 ms 282 ms +37.74%
test_show[100 Small Files] 23.1 ms 41.1 ms -43.76%

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (ec39dc0) to head (627881b).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3400      +/-   ##
==========================================
+ Coverage   76.54%   77.34%   +0.80%     
==========================================
  Files         685      684       -1     
  Lines       85269    83622    -1647     
==========================================
- Hits        65266    64681     -585     
+ Misses      20003    18941    -1062     
Files with missing lines Coverage Δ
src/common/io-config/src/python.rs 49.59% <100.00%> (-0.90%) ⬇️

... and 25 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member

@samster25 samster25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kevinzwang kevinzwang merged commit 2ae53f4 into main Nov 23, 2024
43 of 44 checks passed
@kevinzwang kevinzwang deleted the kevin/io-config-bin-serde branch November 23, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants