Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] delete empty file xyz #3370

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[CHORE] delete empty file xyz #3370

merged 1 commit into from
Nov 20, 2024

Conversation

andrewgazelka
Copy link
Contributor

No description provided.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andrewgazelka andrewgazelka marked this pull request as ready for review November 20, 2024 23:07
@andrewgazelka andrewgazelka changed the title [REFACTOR] delete empty file xyz [CHORE] delete empty file xyz Nov 20, 2024
@github-actions github-actions bot added the chore label Nov 20, 2024
Copy link

graphite-app bot commented Nov 20, 2024

Graphite Automations

"Notify author when CI fails" took an action on this PR • (11/20/24)

1 teammate was notified to this PR based on Andrew Gazelka's automation.

"Request reviewers once CI passes" took an action on this PR • (11/20/24)

1 reviewer was added to this PR based on Andrew Gazelka's automation.

Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #3370 will improve performances by 62.22%

Comparing andrew/delete-xyz (3938931) with main (b6695eb)

Summary

⚡ 2 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark main andrew/delete-xyz Change
test_iter_rows_first_row[100 Small Files] 345.3 ms 212.8 ms +62.22%
test_show[100 Small Files] 32.7 ms 23.4 ms +39.89%

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.44%. Comparing base (b6695eb) to head (3938931).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3370      +/-   ##
==========================================
+ Coverage   77.39%   77.44%   +0.04%     
==========================================
  Files         678      678              
  Lines       83300    83291       -9     
==========================================
+ Hits        64469    64501      +32     
+ Misses      18831    18790      -41     

see 6 files with indirect coverage changes

---- 🚨 Try these New Features:

@andrewgazelka andrewgazelka merged commit 5fee192 into main Nov 20, 2024
46 of 47 checks passed
Copy link
Contributor Author

Merge activity

  • Nov 20, 6:28 PM EST: A user merged this pull request with Graphite.

@andrewgazelka andrewgazelka deleted the andrew/delete-xyz branch November 20, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants