Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Scaffolding for df.write_table #3323

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Nov 18, 2024

No description provided.

Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #3323 will degrade performances by 27.54%

Comparing jay/write-table (0cf9c19) with main (dc42571)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jay/write-table Change
test_iter_rows_first_row[100 Small Files] 382.9 ms 329.3 ms +16.28%
test_show[100 Small Files] 23.9 ms 33 ms -27.54%

@github-actions github-actions bot added the enhancement New feature or request label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.38%. Comparing base (bb506a4) to head (0cf9c19).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
daft/dataframe/dataframe.py 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3323   +/-   ##
=======================================
  Coverage   77.38%   77.38%           
=======================================
  Files         676      676           
  Lines       82602    82607    +5     
=======================================
+ Hits        63922    63928    +6     
+ Misses      18680    18679    -1     
Files with missing lines Coverage Δ
daft/dataframe/dataframe.py 86.58% <66.66%> (-0.07%) ⬇️

... and 5 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant