-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Support for correlated subqueries in SQL (not yet executable) #3304
Conversation
CodSpeed Performance ReportMerging #3304 will degrade performances by 20.38%Comparing Summary
Benchmarks breakdown
|
I think I broke sql_expr, will try to fix that tomorrow |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3304 +/- ##
==========================================
- Coverage 77.55% 77.42% -0.14%
==========================================
Files 668 676 +8
Lines 82268 82660 +392
==========================================
+ Hits 63807 64003 +196
- Misses 18461 18657 +196
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one question, otherwise looks good.
This PR adds support for converting SQL queries with correlated subqueries into LogicalPlans. It does not add the ability to execute queries with correlated subqueries, but if I am correct, this is the last large piece of support we need on the SQL side for TPC-H questions, and most of the remaining work is plan rewriting, optimization, and translation.
I believe with the new
alias_map
value inSQLPlanner
, we can actually simplify a lot of the logic inplan_aggregate_query
andplan_non_agg_query
but I will not attempt to do that in this PR.Relevant for TPC-H questions 4, 17, 20, 21, 22.
Todo: