Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update incomplete SQL doc pages #3298

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

willvo2004
Copy link
Contributor

Closes #3268

Still WIP. Awaiting approval for current document updates

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 14, 2024
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #3298 will degrade performances by 46.37%

Comparing willvo2004:issuedoc1 (96c0f4a) with main (711e862)

Summary

❌ 3 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main willvo2004:issuedoc1 Change
test_count[1 Small File] 3.6 ms 4 ms -11.31%
test_iter_rows_first_row[100 Small Files] 269 ms 380.8 ms -29.36%
test_show[100 Small Files] 22.3 ms 41.5 ms -46.37%

@willvo2004 willvo2004 marked this pull request as ready for review November 14, 2024 13:04
@willvo2004
Copy link
Contributor Author

Looking into issue with search page brought up in original issue.
image
Maybe can be opened in seperate issue?

@universalmind303 universalmind303 merged commit 05048d9 into Eventual-Inc:main Nov 14, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Update incomplete SQL doc pages
2 participants