Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: SQL read_csv #3255

Merged
merged 9 commits into from
Nov 19, 2024
Merged

[FEAT]: SQL read_csv #3255

merged 9 commits into from
Nov 19, 2024

Conversation

itzhakstern
Copy link
Contributor

Add the functionality to read from csv file in a sql query

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3255 will improve performances by ×2.2

Comparing itzhakstern:itzhaks/sql-read-csv-function (e3c277c) with main (84db665)

Summary

⚡ 2 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark main itzhakstern:itzhaks/sql-read-csv-function Change
⚡ test_iter_rows_first_row[100 Small Files] 421.4 ms 376.3 ms +11.97%
⚡ test_show[100 Small Files] 32.7 ms 14.8 ms ×2.2

@universalmind303 universalmind303 changed the title init [DRAFT]: SQL read_csv Nov 11, 2024
@itzhakstern itzhakstern changed the title [DRAFT]: SQL read_csv [FEAT]: SQL read_csv Nov 13, 2024
@github-actions github-actions bot added the enhancement New feature or request label Nov 13, 2024
@itzhakstern itzhakstern marked this pull request as ready for review November 13, 2024 12:08
@itzhakstern itzhakstern marked this pull request as draft November 13, 2024 12:09
@itzhakstern itzhakstern marked this pull request as ready for review November 14, 2024 16:44
universalmind303
universalmind303 requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes, but overall looks good!

src/daft-sql/src/table_provider/read_csv.rs Outdated Show resolved Hide resolved
tests/sql/test_table_funcs.py Outdated Show resolved Hide resolved
tests/sql/test_table_funcs.py Outdated Show resolved Hide resolved
tests/sql/test_table_funcs.py Outdated Show resolved Hide resolved
@universalmind303
Copy link
Contributor

thanks @itzhakstern

@universalmind303 universalmind303 merged commit 1b84250 into Eventual-Inc:main Nov 19, 2024
40 checks passed
@universalmind303 universalmind303 mentioned this pull request Jan 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@universalmind303 universalmind303 universalmind303 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itzhakstern @universalmind303