[FEAT]: sql concat and stddev #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3153 will not alter performanceComparing Summary
|
kevinzwang
approved these changes
Oct 30, 2024
src/daft-sql/src/modules/utf8.rs
Outdated
Comment on lines
547
to
568
| impl SQLFunction for SQLConcat { | ||
| fn to_expr( | ||
| &self, | ||
| inputs: &[sqlparser::ast::FunctionArg], | ||
| planner: &crate::planner::SQLPlanner, | ||
| ) -> SQLPlannerResult<ExprRef> { | ||
| let inputs = inputs | ||
| .iter() | ||
| .map(|input| planner.plan_function_arg(input)) | ||
| .collect::<SQLPlannerResult<Vec<_>>>()?; | ||
| let mut inputs = inputs.into_iter(); | ||
|
|
||
| let Some(mut first) = inputs.next() else { | ||
| invalid_operation_err!("concat requires at least one argument") | ||
| }; | ||
| for input in inputs { | ||
| first = binary_op(Operator::Plus, first, input); | ||
| } | ||
|
|
||
| Ok(first) | ||
| } | ||
| } |
There was a problem hiding this comment.
There's a lot of different things that are called concat in Daft (the agg expr, concatting two tables, and now this). Would appreciate some doc strings just to make it easier to understand at a glance what this one does, and why it uses the plus operator.
| @@ -62,7 +62,8 @@ def test_utf8_exprs(): | |||
| normalize(a, remove_punct:=true, lowercase:=true) as normalize_remove_punct_lower_a, | |||
| normalize(a, remove_punct:=true, lowercase:=true, white_space:=true) as normalize_remove_punct_lower_ws_a, | |||
| tokenize_encode(a, 'r50k_base') as tokenize_encode_a, | |||
| tokenize_decode(tokenize_encode(a, 'r50k_base'), 'r50k_base') as tokenize_decode_a | |||
| tokenize_decode(tokenize_encode(a, 'r50k_base'), 'r50k_base') as tokenize_decode_a, | |||
| concat(a, '---') as concat_a, | |||
There was a problem hiding this comment.
One more case you could add is concat with more than two arguments, since that should technically be supported too.
sagiahrac
pushed a commit
to sagiahrac/Daft
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.