Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Swordfish perf + cleanup #3132

Closed
wants to merge 12 commits into from

why are my tests not running

8767751
Select commit
Loading
Failed to load commit list.
Closed

[CHORE] Swordfish perf + cleanup #3132

why are my tests not running
8767751
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 26, 2024 in 0s

78.71% (+0.01%) compared to 6569cb6

View this Pull Request on Codecov

78.71% (+0.01%) compared to 6569cb6

Details

Codecov Report

Attention: Patch coverage is 97.65766% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.71%. Comparing base (6569cb6) to head (8767751).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...local-execution/src/sinks/outer_hash_join_probe.rs 88.23% 4 Missing ⚠️
src/daft-local-execution/src/buffer.rs 95.23% 3 Missing ⚠️
src/daft-local-execution/src/sinks/aggregate.rs 96.00% 2 Missing ⚠️
src/daft-local-execution/src/sinks/sort.rs 93.10% 2 Missing ⚠️
src/daft-local-execution/src/lib.rs 96.66% 1 Missing ⚠️
src/daft-local-execution/src/pipeline.rs 94.44% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
+ Coverage   78.69%   78.71%   +0.01%     
==========================================
  Files         619      621       +2     
  Lines       73412    74218     +806     
==========================================
+ Hits        57775    58417     +642     
- Misses      15637    15801     +164     
Files with missing lines Coverage Δ
src/daft-local-execution/src/channel.rs 98.68% <100.00%> (+0.17%) ⬆️
src/daft-local-execution/src/dispatcher.rs 100.00% <100.00%> (ø)
.../src/intermediate_ops/anti_semi_hash_join_probe.rs 100.00% <100.00%> (+5.55%) ⬆️
...ft-local-execution/src/intermediate_ops/explode.rs 100.00% <100.00%> (ø)
...aft-local-execution/src/intermediate_ops/filter.rs 100.00% <ø> (ø)
...tion/src/intermediate_ops/inner_hash_join_probe.rs 99.10% <100.00%> (+3.34%) ⬆️
...-execution/src/intermediate_ops/intermediate_op.rs 78.78% <100.00%> (-0.95%) ⬇️
...daft-local-execution/src/intermediate_ops/pivot.rs 100.00% <100.00%> (ø)
...ft-local-execution/src/intermediate_ops/project.rs 100.00% <ø> (ø)
...aft-local-execution/src/intermediate_ops/sample.rs 100.00% <ø> (ø)
... and 16 more

... and 6 files with indirect coverage changes