Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix type widening for rem #3131

Merged
merged 4 commits into from
Oct 28, 2024

rebase

f6fff6a
Select commit
Loading
Failed to load commit list.
Merged

[BUG] fix type widening for rem #3131

rebase
f6fff6a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 27, 2024 in 0s

78.68% (+0.38%) compared to 915467b

View this Pull Request on Codecov

78.68% (+0.38%) compared to 915467b

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (915467b) to head (f6fff6a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3131      +/-   ##
==========================================
+ Coverage   78.30%   78.68%   +0.38%     
==========================================
  Files         620      621       +1     
  Lines       74691    74284     -407     
==========================================
- Hits        58484    58449      -35     
+ Misses      16207    15835     -372     
Files with missing lines Coverage Δ
daft/datatype.py 91.89% <100.00%> (+0.04%) ⬆️
src/daft-core/src/datatypes/infer_datatype.rs 88.44% <100.00%> (+2.05%) ⬆️
src/daft-core/src/series/ops/arithmetic.rs 84.29% <ø> (ø)
src/daft-schema/src/python/datatype.rs 81.22% <100.00%> (+0.19%) ⬆️

... and 17 files with indirect coverage changes