Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Cancel tasks spawned on compute runtime #3128

Merged
merged 3 commits into from
Oct 31, 2024

Merge branch main into colin/runtime-task-cancel

ab10825
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] Cancel tasks spawned on compute runtime #3128

Merge branch main into colin/runtime-task-cancel
ab10825
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2024 in 0s

79.00% (-0.01%) compared to 5fc9531

View this Pull Request on Codecov

79.00% (-0.01%) compared to 5fc9531

Details

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.00%. Comparing base (5fc9531) to head (ab10825).

Files with missing lines Patch % Lines
src/common/runtime/src/lib.rs 97.72% 1 Missing ⚠️
src/daft-local-execution/src/sources/scan_task.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
- Coverage   79.00%   79.00%   -0.01%     
==========================================
  Files         634      634              
  Lines       76912    76936      +24     
==========================================
+ Hits        60763    60781      +18     
- Misses      16149    16155       +6     
Files with missing lines Coverage Δ
...-execution/src/intermediate_ops/intermediate_op.rs 82.05% <ø> (ø)
...rc/daft-local-execution/src/sinks/blocking_sink.rs 81.65% <100.00%> (ø)
...c/daft-local-execution/src/sinks/streaming_sink.rs 83.55% <100.00%> (ø)
src/daft-scan/src/glob.rs 88.96% <100.00%> (-0.04%) ⬇️
src/common/runtime/src/lib.rs 90.78% <97.72%> (+2.18%) ⬆️
src/daft-local-execution/src/sources/scan_task.rs 72.50% <0.00%> (ø)

... and 2 files with indirect coverage changes