Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Cancel tasks spawned on compute runtime #3128

Merged
merged 3 commits into from
Oct 31, 2024

encapsulate the task in a struct, map_err to dafterror

ab26801
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] Cancel tasks spawned on compute runtime #3128

encapsulate the task in a struct, map_err to dafterror
ab26801
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2024 in 0s

78.89% (+0.26%) compared to 5b450fb

View this Pull Request on Codecov

78.89% (+0.26%) compared to 5b450fb

Details

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.89%. Comparing base (5b450fb) to head (ab26801).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/common/runtime/src/lib.rs 97.72% 1 Missing ⚠️
src/daft-local-execution/src/sources/scan_task.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
+ Coverage   78.62%   78.89%   +0.26%     
==========================================
  Files         621      624       +3     
  Lines       74125    75973    +1848     
==========================================
+ Hits        58284    59938    +1654     
- Misses      15841    16035     +194     
Files with missing lines Coverage Δ
...-execution/src/intermediate_ops/intermediate_op.rs 82.16% <ø> (+2.43%) ⬆️
...rc/daft-local-execution/src/sinks/blocking_sink.rs 74.39% <100.00%> (ø)
...c/daft-local-execution/src/sinks/streaming_sink.rs 83.55% <100.00%> (ø)
src/daft-scan/src/glob.rs 88.96% <100.00%> (-0.04%) ⬇️
src/common/runtime/src/lib.rs 90.78% <97.72%> (+2.18%) ⬆️
src/daft-local-execution/src/sources/scan_task.rs 72.50% <0.00%> (ø)

... and 81 files with indirect coverage changes