[FEAT]: sql IN operator
#3086
Merged
[FEAT]: sql IN operator
#3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3086 will not alter performanceComparing Summary
|
universalmind303
requested review from
kevinzwang,
andrewgazelka and
desmondcheongzx
andrewgazelka
approved these changes
Oct 22, 2024
| let list = list | ||
| .iter() | ||
| .map(|e| self.plan_lit(e)) | ||
| .collect::<SQLPlannerResult<Vec<_>>>()?; |
There was a problem hiding this comment.
nit:
Suggested change
| .collect::<SQLPlannerResult<Vec<_>>>()?; | |
| .try_collect()?; |
and then let list: Vec<_> = ...
This is more appealing to me. Can be done with itertools or since we are using nightly it is a feature as well.
| let series = literals_to_series(&list)?; | ||
| let series_lit = LiteralValue::Series(series); | ||
| let series_expr = Expr::Literal(series_lit); | ||
| let series_expr_arc = Arc::new(series_expr); |
There was a problem hiding this comment.
nit: use shadowing here (best practice)
https://www.perplexity.ai/search/is-shadowing-best-practice-rus-Acz8Mve6Qy6gZvxbtYDjTA#0
| let series_expr = Expr::Literal(series_lit); | ||
| let series_expr_arc = Arc::new(series_expr); | ||
| let expr = expr.is_in(series_expr_arc); | ||
| if *negated { |
There was a problem hiding this comment.
this seems to be repeated a bunch. don't know if there is a way to make this simpler negate_if ? or if this is just a bit too much. I could see accidentally missing .not in one of these. unsure though feel free to do nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3085