[CHORE] Auto attach LLDB debugger to python #2940

[sagiahrac]

#2940

@andrewgazelka

[codspeed-hq]

CodSpeed Performance Report

Merging #3020 will not alter performance

_{Comparing sagiahrac:auto-attach-lldb-debugger (3dda6bb) with main (a3453d1)}

Summary

✅ 17 untouched benchmarks

[andrewgazelka]

#2940

@andrewgazelka

Thank you will review this later today

[andrewgazelka]

Is there a reason we don't include the launch.json file directly in the main repository and instead have it in a Markdown document? It seems like it would be easier if it were directly in the repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.44%. Comparing base (396c004) to head (d9b2f50).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3020      +/-   ##
==========================================
+ Coverage   78.36%   78.44%   +0.08%     
==========================================
  Files         602      603       +1     
  Lines       71082    71506     +424     
==========================================
+ Hits        55701    56092     +391     
- Misses      15381    15414      +33     

see 202 files with indirect coverage changes

[sagiahrac]

Is there a reason we don't include the launch.json file directly in the main repository and instead have it in a Markdown document? It seems like it would be easier if it were directly in the repository.

Personally, I sometimes include sensitive tokens as environment variables in the launch.json file. Untracking the .vscode directory could help avoid unintentionally altering other users' configurations or accidentally leaking sensitive information... What do you think?

[andrewgazelka]

hey @sagiahrac sorry for taking so long!

Great! it works :)

thoughts on me removing justMyCode? thinking we might want to debug some libraries that are not our code.

3dda6bb

after we resolve I will approve and merge. again thanks for your time and sorry for the wait.

[sagiahrac]

@andrewgazelka no problem :)

I believe the Debug Rust/Python configuration is responsible only for launching the LLDB process and passing its PID (along with the file name we want to debug) to the other configuration. In this case, I think Debug Rust/Python should only need to be aware of tools/attach_debugger.py, while the other configuration is responsible for handling breakpoints. I'm not sure if justMyCode should influence the scope that our LLDB process considers during debugging.

Either way, we can omit it just to be certain