Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Infer timedelta literal as duration #3011

Merged
merged 3 commits into from
Oct 7, 2024
Merged

[FEAT] Infer timedelta literal as duration #3011

merged 3 commits into from
Oct 7, 2024

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Oct 7, 2024

Closes #2991

@github-actions github-actions bot added the enhancement New feature or request label Oct 7, 2024
Copy link

codspeed-hq bot commented Oct 7, 2024

CodSpeed Performance Report

Merging #3011 will not alter performance

Comparing colin/timedelta (519e820) with main (396c004)

Summary

✅ 17 untouched benchmarks

Copy link
Contributor

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 78.35%. Comparing base (396c004) to head (519e820).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-core/src/array/ops/repr.rs 0.00% 11 Missing ⚠️
src/daft-core/src/utils/display.rs 84.61% 4 Missing ⚠️
src/daft-dsl/src/lit.rs 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3011      +/-   ##
==========================================
- Coverage   78.36%   78.35%   -0.01%     
==========================================
  Files         602      602              
  Lines       71082    71140      +58     
==========================================
+ Hits        55701    55741      +40     
- Misses      15381    15399      +18     
Files with missing lines Coverage Δ
daft/expressions/expressions.py 93.74% <100.00%> (+0.05%) ⬆️
src/daft-dsl/src/lib.rs 100.00% <100.00%> (ø)
src/daft-dsl/src/python.rs 91.84% <100.00%> (+0.08%) ⬆️
src/daft-dsl/src/lit.rs 54.85% <90.00%> (+1.31%) ⬆️
src/daft-core/src/utils/display.rs 72.34% <84.61%> (+4.69%) ⬆️
src/daft-core/src/array/ops/repr.rs 67.69% <0.00%> (-2.66%) ⬇️

... and 2 files with indirect coverage changes

@colin-ho colin-ho merged commit f5cf5af into main Oct 7, 2024
39 of 40 checks passed
@colin-ho colin-ho deleted the colin/timedelta branch October 7, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to cast python timedelta to Duration
2 participants