Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] add/fix many clippy lints #2978

Merged
merged 10 commits into from
Oct 7, 2024

re fmt/lint

a1b9c8c
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] add/fix many clippy lints #2978

re fmt/lint
a1b9c8c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2024 in 1s

78.16% (-0.22%) compared to 98dbadb

View this Pull Request on Codecov

78.16% (-0.22%) compared to 98dbadb

Details

Codecov Report

Attention: Patch coverage is 67.05882% with 392 lines in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (98dbadb) to head (a1b9c8c).

Files with missing lines Patch % Lines
src/daft-table/src/python.rs 5.00% 38 Missing ⚠️
src/daft-core/src/array/ops/get.rs 26.66% 22 Missing ⚠️
src/daft-scan/src/lib.rs 16.66% 20 Missing ⚠️
src/daft-io/src/azure_blob.rs 0.00% 15 Missing ⚠️
src/common/file-formats/src/file_format_config.rs 17.64% 14 Missing ⚠️
src/daft-io/src/huggingface.rs 6.66% 14 Missing ⚠️
src/common/io-config/src/python.rs 58.62% 12 Missing ⚠️
src/daft-local-execution/src/sources/source.rs 0.00% 12 Missing ⚠️
src/common/io-config/src/s3.rs 9.09% 10 Missing ⚠️
src/daft-io/src/google_cloud.rs 0.00% 9 Missing ⚠️
... and 87 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2978      +/-   ##
==========================================
- Coverage   78.37%   78.16%   -0.22%     
==========================================
  Files         603      603              
  Lines       71466    71850     +384     
==========================================
+ Hits        56009    56159     +150     
- Misses      15457    15691     +234
Files with missing lines Coverage Δ
src/common/daft-config/src/lib.rs 87.50% <ø> (ø)
src/common/daft-config/src/python.rs 77.34% <ø> (ø)
src/common/display/src/ascii.rs 0.00% <ø> (ø)
src/common/display/src/tree.rs 37.50% <100.00%> (+8.92%) ⬆️
src/common/display/src/utils.rs 0.00% <ø> (ø)
src/common/io-config/src/config.rs 37.50% <ø> (ø)
src/common/io-config/src/lib.rs 58.06% <100.00%> (ø)
src/common/py-serde/src/python.rs 77.77% <ø> (ø)
src/common/system-info/src/lib.rs 96.15% <100.00%> (ø)
src/common/treenode/src/lib.rs 94.11% <100.00%> (ø)
... and 250 more

... and 5 files with indirect coverage changes

View more details on Codecov