-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Enable concat for swordfish #2976
Conversation
CodSpeed Performance ReportMerging #2976 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2976 +/- ##
==========================================
+ Coverage 77.35% 78.63% +1.28%
==========================================
Files 615 616 +1
Lines 74412 73147 -1265
==========================================
- Hits 57561 57520 -41
+ Misses 16851 15627 -1224
|
a2ca316
to
fe2c0b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One todo for the future: loosen index ordering requirement when downstream ops do not need data to be ordered. That way the right side can start computation before the left side is done.
Implement concat as a streaming sink in swordfish.
Concatenating two dataframes in a streaming executor is pretty simple. You just stream the left side, then stream the right side. This PR implements just that.