Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] use cargo-machete in pre-commit hook #2929

Closed
wants to merge 3 commits into from

Conversation

andrewgazelka
Copy link
Member

questions:

  • can we install it somehow? how about a pinned version?
  • which order should it be in?
  • am I doing this right? I am not familiar with pre-commit

@samster25
Copy link
Member

This one is a bit tricky since this will require everyone who is developing in daft to have cargo machete installed on their machine. We can assume folks will have rust fmt and clippy installed but this might be a stretch!

One work around is to invoke a shell script for the hook that first checks if cargo machete is installed and prints out a warning on how to install it

Copy link

codspeed-hq bot commented Sep 25, 2024

CodSpeed Performance Report

Merging #2929 will not alter performance

Comparing andrew/pre-commit-machete (bd6b6e4) with main (62d0581)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.31%. Comparing base (62d0581) to head (bd6b6e4).
Report is 74 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2929      +/-   ##
==========================================
- Coverage   78.32%   78.31%   -0.02%     
==========================================
  Files         602      602              
  Lines       71047    71047              
==========================================
- Hits        55648    55640       -8     
- Misses      15399    15407       +8     

see 6 files with indirect coverage changes

@andrewgazelka andrewgazelka force-pushed the andrew/pre-commit-machete branch from be3a6a8 to ba9adbb Compare October 1, 2024 20:23
@andrewgazelka
Copy link
Member Author

This one is a bit tricky since this will require everyone who is developing in daft to have cargo machete installed on their machine. We can assume folks will have rust fmt and clippy installed but this might be a stretch!

One work around is to invoke a shell script for the hook that first checks if cargo machete is installed and prints out a warning on how to install it

ba9adbb

should fix this

@andrewgazelka andrewgazelka force-pushed the andrew/pre-commit-machete branch from 03bc129 to 91f1f69 Compare October 1, 2024 20:41
questions:
- can we install it somehow? how about a pinned version?
- which order should it be in?
- am I doing this right? I am not familiar with `pre-commit`
@andrewgazelka andrewgazelka force-pushed the andrew/pre-commit-machete branch from afd1850 to bd6b6e4 Compare October 4, 2024 01:47
@samster25 samster25 closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants