-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] add list.value_counts()
#2902
Conversation
CodSpeed Performance ReportMerging #2902 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2902 +/- ##
==========================================
+ Coverage 76.34% 78.36% +2.01%
==========================================
Files 597 603 +6
Lines 71388 71464 +76
==========================================
+ Hits 54504 56002 +1498
+ Misses 16884 15462 -1422
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b983578
to
ba181af
Compare
a4e1c7b
to
e063b04
Compare
9aee66d
to
4a6850a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flushing what I have right now, seems you wanted to iterate a bit more on it.
Could we also update the PR description so we get a proper commit message?
78fa527
to
dcc0a36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussing offline---what happens with lists of nested values?
Also, could we add this new expression to docs/source/api_docs/expressions.rst
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for all the changes!
This PR implements the
list.value_counts()
function and refactors Map types to use a more explicit key-value structure. It also includes various improvements and bug fixes across the codebase.Key changes
Implemented list.value_counts() function
Refactored Map type representation
DataType
enum insrc/daft-schema/src/dtype.rs
to use explicit key and value typesImproved error handling and type checking
Performance optimizations
Code cleanup and minor improvements