Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix concat expression typing #2868

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[BUG] Fix concat expression typing #2868

merged 1 commit into from
Sep 20, 2024

Conversation

colin-ho
Copy link
Contributor

@github-actions github-actions bot added the bug Something isn't working label Sep 20, 2024
Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #2868 will degrade performances by 52.51%

Comparing colin/fix-concat-expr (ff7b050) with main (78a92a2)

Summary

❌ 3 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main colin/fix-concat-expr Change
test_count[1 Small File] 9.9 ms 16.7 ms -40.4%
test_explain[100 Small Files] 33 ms 69.5 ms -52.51%
test_show[100 Small Files] 257.9 ms 315.1 ms -18.16%

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.93%. Comparing base (7ee5fda) to head (ff7b050).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2868      +/-   ##
==========================================
+ Coverage   64.12%   65.93%   +1.80%     
==========================================
  Files        1008     1010       +2     
  Lines      115728   113441    -2287     
==========================================
+ Hits        74215    74801     +586     
+ Misses      41513    38640    -2873     
Flag Coverage Δ
65.93% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
daft/expressions/expressions.py 93.37% <100.00%> (-0.13%) ⬇️

... and 77 files with indirect coverage changes

@colin-ho colin-ho requested a review from jaychia September 20, 2024 17:22
@colin-ho colin-ho merged commit c481f1b into main Sep 20, 2024
39 of 40 checks passed
@colin-ho colin-ho deleted the colin/fix-concat-expr branch September 20, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants