Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE]: move numeric out of daft-dsl and into daft-functions #2857

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

universalmind303
Copy link
Contributor

No description provided.

Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #2857 will degrade performances by 49.42%

Comparing universalmind303:sql-numerics (6f2e863) with main (c5b7062)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:sql-numerics Change
test_count[1 Small File] 18.7 ms 17 ms +10.22%
test_explain[100 Small Files] 37.4 ms 33.4 ms +11.91%
test_show[100 Small Files] 56.2 ms 111.1 ms -49.42%

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that aside from to_field_single_numeric, to_field_single_floating, and evaluate_single_numeric, there were no changes to the functions with this move, in which case LGTM

@universalmind303 universalmind303 merged commit 134601b into Eventual-Inc:main Sep 23, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants