Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add a list.contains API #2773

Closed
wants to merge 7 commits into from

Change message in assertion

d63ce68
Select commit
Loading
Failed to load commit list.
Closed

[FEAT] Add a list.contains API #2773

Change message in assertion
d63ce68
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 21, 2024 in 1s

77.35% (-0.07%) compared to 5fee192

View this Pull Request on Codecov

77.35% (-0.07%) compared to 5fee192

Details

Codecov Report

Attention: Patch coverage is 2.46914% with 79 lines in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (5fee192) to head (d63ce68).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-functions/src/list/contains.rs 0.00% 48 Missing ⚠️
src/daft-core/src/array/ops/list.rs 0.00% 16 Missing ⚠️
src/daft-core/src/series/ops/list.rs 0.00% 14 Missing ⚠️
daft/expressions/expressions.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
- Coverage   77.41%   77.35%   -0.07%     
==========================================
  Files         678      679       +1     
  Lines       83680    83332     -348     
==========================================
- Hits        64783    64460     -323     
+ Misses      18897    18872      -25     
Files with missing lines Coverage Δ
src/daft-functions/src/list/mod.rs 100.00% <100.00%> (ø)
daft/expressions/expressions.py 93.26% <50.00%> (-0.12%) ⬇️
src/daft-core/src/series/ops/list.rs 58.55% <0.00%> (-5.95%) ⬇️
src/daft-core/src/array/ops/list.rs 92.39% <0.00%> (-2.14%) ⬇️
src/daft-functions/src/list/contains.rs 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

---- 🚨 Try these New Features: