Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add marker prefixes to filter during reads #2726

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

colin-ho
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Aug 26, 2024
Copy link

codspeed-hq bot commented Aug 26, 2024

CodSpeed Performance Report

Merging #2726 will not alter performance

Comparing colin/add-marker-prefixes (b8e45f4) with main (20ffed4)

Summary

✅ 10 untouched benchmarks

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@20ffed4). Learn more about missing BASE report.
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2726   +/-   ##
=======================================
  Coverage        ?   63.32%           
=======================================
  Files           ?      981           
  Lines           ?   113201           
  Branches        ?        0           
=======================================
  Hits            ?    71681           
  Misses          ?    41520           
  Partials        ?        0           
Files Coverage Δ
src/daft-io/src/object_store_glob.rs 78.34% <100.00%> (ø)

@colin-ho colin-ho marked this pull request as ready for review August 26, 2024 17:56
@colin-ho colin-ho requested a review from jaychia August 26, 2024 17:57
@colin-ho colin-ho merged commit 9e8506e into main Aug 27, 2024
48 checks passed
@colin-ho colin-ho deleted the colin/add-marker-prefixes branch August 27, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants