-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add upload functionality to binary columns #2461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaychia
changed the title
[FEAT] Add upload functinoality to binary columns
[FEAT] Add upload functionality to binary columns
Jul 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2461 +/- ##
=======================================
Coverage ? 63.48%
=======================================
Files ? 951
Lines ? 107050
Branches ? 0
=======================================
Hits ? 67960
Misses ? 39090
Partials ? 0
|
jaychia
force-pushed
the
jay/write-bytes-s3
branch
from
July 3, 2024 18:16
394392f
to
83178b1
Compare
desmondcheongzx
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions, but otherwise LGTM
jaychia
commented
Jul 8, 2024
jaychia
commented
Jul 8, 2024
jaychia
commented
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
.url.upload()
When uploading 300,000 small 300kb files, network peaks at about 5Gbps on a 12Gbps machine:
Follow-ons:
bytes::Bytes
object to the AWS SDK's put request builder. More profiling needs to be done to understand issues there.