Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Add str.right() function #2031

Merged
merged 5 commits into from
Mar 26, 2024
Merged

[FEAT] Add str.right() function #2031

merged 5 commits into from
Mar 26, 2024

Conversation

murex971
Copy link
Contributor

Resolves #1927

@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (afd6a75) to head (39211dd).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2031   +/-   ##
=======================================
  Coverage   84.74%   84.74%           
=======================================
  Files          62       62           
  Lines        6803     6819   +16     
=======================================
+ Hits         5765     5779   +14     
- Misses       1038     1040    +2
Files Coverage Δ
daft/expressions/expressions.py 91.63% <100.00%> (+0.10%) ⬆️
daft/series.py 93.23% <100.00%> (+0.10%) ⬆️

... and 1 file with indirect coverage changes

@colin-ho colin-ho added the enhancement New feature or request label Mar 22, 2024
colin-ho
colin-ho approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@colin-ho colin-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow @murex971 super fast work! Mostly LGTM, just left a few nits

src/daft-dsl/src/functions/utf8/right.rs Outdated Show resolved Hide resolved
daft/daft.pyi Outdated Show resolved Hide resolved
daft/daft.pyi Outdated Show resolved Hide resolved
daft/series.py Outdated Show resolved Hide resolved
src/daft-core/src/python/series.rs Outdated Show resolved Hide resolved
src/daft-dsl/src/functions/utf8/left.rs Show resolved Hide resolved
src/daft-core/src/array/ops/utf8.rs Outdated Show resolved Hide resolved
@murex971
Copy link
Contributor Author

Mostly LGTM, just left a few nits

@colin-ho done

colin-ho
colin-ho reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@colin-ho colin-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @murex971 ! Missed a couple things in the last review if you could help fix, otherwise everything's lookin good!

src/daft-core/src/array/ops/utf8.rs Outdated Show resolved Hide resolved
tests/series/test_utf8_ops.py Show resolved Hide resolved
@colin-ho
Copy link
Contributor

Great stuff @murex971 !!

@colin-ho colin-ho merged commit 841e9a9 into Eventual-Inc:main Mar 26, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-ho colin-ho colin-ho approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EXPRESSIONS] .str.right
2 participants
@murex971 @colin-ho