[FEAT] Add str.lstrip() and str.rstrip() functions #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
==========================================
- Coverage 85.60% 85.56% -0.05%
==========================================
Files 55 55
Lines 6226 6236 +10
==========================================
+ Hits 5330 5336 +6
- Misses 896 900 +4
|
* Added the `lstrip` function to match https://ibis-project.org/reference/expression-strings#ibis.expr.types.strings.StringValue.lstrip * Added the `rstrip` function to match https://ibis-project.org/reference/expression-strings#ibis.expr.types.strings.StringValue.rstrip * Added tests showing example usage Closes Eventual-Inc#1922 and Eventual-Inc#1923
nsalerni
force-pushed
the
numeric-lrstrip
branch
from
4c2f81e to
0698d80
Compare
samster25
approved these changes
Feb 23, 2024
samster25
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Added the `lstrip` function to match https://ibis-project.org/reference/expression-strings#ibis.expr.types.strings.StringValue.lstrip * Added the `rstrip` function to match https://ibis-project.org/reference/expression-strings#ibis.expr.types.strings.StringValue.rstrip * Added tests showing example usage Closes #1922 and #1923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lstripfunction to match https://ibis-project.org/reference/expression-strings#ibis.expr.types.strings.StringValue.lstriprstripfunction to match https://ibis-project.org/reference/expression-strings#ibis.expr.types.strings.StringValue.rstripCloses #1922 and #1923