[FEAT] Add str.upper() function #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding the `upper` function to match https://ibis-project.org/reference/expression-strings#ibis.expr.types.strings.StringValue.upper * Added tests showing example usage * Refactor tests for str.lower to be a single parameterized test Closes Eventual-Inc#1920
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1942 +/- ##
==========================================
+ Coverage 85.51% 85.57% +0.05%
==========================================
Files 55 55
Lines 6221 6226 +5
==========================================
+ Hits 5320 5328 +8
+ Misses 901 898 -3
|
samster25
approved these changes
Feb 22, 2024
|
|
||
| def test_series_utf8_lower_all_null() -> None: | ||
| s = Series.from_arrow(pa.array([None, None, None])) | ||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
Very nice, refactoring this to be parameterized!
|
@nsalerni Thanks for knocking out another one! |
samster25
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Adding the `upper` function to match https://ibis-project.org/reference/expression-strings#ibis.expr.types.strings.StringValue.upper * Added tests showing example usage * Refactor tests for str.lower to be a single parameterized test Closes #1920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upperfunction to match https://ibis-project.org/reference/expression-strings#ibis.expr.types.strings.StringValue.upperCloses #1920