Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Expose coerce_int96_timestamp_unit flag on top level daft.read_parquet call #1936

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

samster25
Copy link
Member

closes: #1894

@github-actions github-actions bot added the enhancement New feature or request label Feb 20, 2024
@clarkzinzow
Copy link
Contributor

@samster25 Just pushed a commit that should fix the non-MicroPartition path!

@clarkzinzow
Copy link
Contributor

@samster25 Looks like the non-MicroPartition path is still broken, not sure what the required fix is.

Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, good to merge once we rebase on main which no longer has the old MicroPartition=0 tests

@samster25 samster25 force-pushed the sammy/1894-parquet-options branch from cedc826 to b844b7e Compare February 27, 2024 20:14
@samster25 samster25 enabled auto-merge (squash) February 27, 2024 20:15
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.92%. Comparing base (cc7b957) to head (cedc826).

❗ Current head cedc826 differs from pull request most recent head b844b7e. Consider uploading reports for the commit b844b7e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
+ Coverage   83.90%   83.92%   +0.02%     
==========================================
  Files          55       55              
  Lines        6112     6115       +3     
==========================================
+ Hits         5128     5132       +4     
+ Misses        984      983       -1     
Files Coverage Δ
daft/io/_parquet.py 95.45% <80.00%> (-4.55%) ⬇️

... and 1 file with indirect coverage changes

@samster25 samster25 merged commit e6c4970 into main Feb 27, 2024
27 checks passed
@samster25 samster25 deleted the sammy/1894-parquet-options branch February 27, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose coerce_int96_timestamp_unit flag on top level daft.read_parquet call
3 participants