Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update schema hints documentation #1935

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Feb 20, 2024

Schema hint documentation was out of date after: #1636

This PR fixes our docs

@jaychia jaychia requested a review from colin-ho February 20, 2024 22:50
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b702e4d) 85.55% compared to head (e4cd5a3) 85.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1935      +/-   ##
==========================================
- Coverage   85.55%   85.42%   -0.13%     
==========================================
  Files          55       55              
  Lines        6216     6216              
==========================================
- Hits         5318     5310       -8     
- Misses        898      906       +8     
Files Coverage Δ
daft/io/_csv.py 95.23% <ø> (ø)
daft/io/_json.py 100.00% <ø> (ø)
daft/io/_parquet.py 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@jaychia jaychia merged commit d115e19 into main Feb 21, 2024
42 checks passed
@jaychia jaychia deleted the jay/read_docs_schema_hints branch February 21, 2024 01:26
samster25 pushed a commit that referenced this pull request Feb 27, 2024
Schema hint documentation was out of date after: #1636 

This PR fixes our docs

Co-authored-by: Jay Chia <[email protected]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants