[BUG] [Query Planner] Properly track ascending/descending sort order for range partitioning and sorting. #1862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we properly track ascending/descending sort order for range partitioning and sorting ops, to ensure that downstream operations correctly interpret the partition spec.
For example, before this PR, the planner would always assume that if both sides of the join are sorted, then they're sorted in ascending order and could therefore be efficiently joined with our sort-merge join (which currently only does ascending-order sorts/merges); this would lead to incorrect results if either side was sorted in descending order.
Closes #1829
Follow-ups (future PRs)
Partitioning
abstraction to Rust to enable better dtype support.