[PERF] Set min_partitions for post aggregation shuffles #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-ho
commented
Feb 9, 2024
src/common/daft-config/src/lib.rs
Outdated
| @@ -51,6 +52,7 @@ impl Default for DaftExecutionConfig { | |||
| parquet_inflation_factor: 3.0, | |||
| csv_target_filesize: 512 * 1024 * 1024, // 512MB | |||
| csv_inflation_factor: 0.5, | |||
| aggregation_min_partitions: 10, | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1861 +/- ##
==========================================
+ Coverage 85.50% 85.55% +0.04%
==========================================
Files 55 55
Lines 6194 6194
==========================================
+ Hits 5296 5299 +3
+ Misses 898 895 -3
|
samster25
reviewed
Feb 12, 2024
daft/context.py
Outdated
| @@ -215,6 +215,7 @@ def set_execution_config( | |||
| parquet_inflation_factor: float | None = None, | |||
| csv_target_filesize: int | None = None, | |||
| csv_inflation_factor: float | None = None, | |||
| aggregation_min_partitions: int | None = None, | |||
There was a problem hiding this comment.
We should rename this to shuffle_aggregation_default_partitions and the default value should be 200 to mimic spark. Also this should be in the planning config!
colin-ho
force-pushed
the
colin/reduce-shuffle-partitions-after-1st-agg
branch
from
ec83263 to
151931c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a config variable to set the minimum partitions produced after first stage aggregations.
Here's a comparison between shuffling with same number of input partitions vs a much smaller number