[BUG] Schema hints not working properly for json reads #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1845 +/- ##
==========================================
- Coverage 85.62% 85.53% -0.10%
==========================================
Files 55 55
Lines 6102 6147 +45
==========================================
+ Hits 5225 5258 +33
- Misses 877 889 +12 |
colin-ho
force-pushed
the
colin/fix-json-reads
branch
from
a9fa929 to
e58d3ef
Compare
jaychia
approved these changes
Feb 8, 2024
tests/dataframe/test_creation.py
Outdated
| @@ -797,6 +797,45 @@ def test_create_dataframe_json_schema_hints_ignore_random_hint(valid_data: list[ | |||
| assert len(pd_df) == len(valid_data) | |||
|
|
|||
|
|
|||
| def test_create_dataframe_json_schema_hints_large_file() -> None: | |||
There was a problem hiding this comment.
Nice test 😵
Another maybe easier way could be to have 2 files (Schema inference is only performed on one file by default at the moment):
# File 1
{"foo": 1}
# File 2
{"bar": 2}
Then we pass in schema hints: {"foo": Int32, "bar": Int32} and we should see the correct result for both rows
There was a problem hiding this comment.
oh yeah i like that a lot better! will do this instead of generating a 1mb json haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema hints were not being propagated, leading to fields being dropped.
This stemmed from an issue when reading large jsons from s3 where the fields changed only late into the file, so schema inference doesn't pick it up.