Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add getter for Struct and List expressions #1775

Merged
merged 9 commits into from
Jan 12, 2024

add list getter (no overrideable default)

a7b5e5e
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] Add getter for Struct and List expressions #1775

add list getter (no overrideable default)
a7b5e5e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2024 in 0s

84.72% (+0.12%) compared to a994c7b

View this Pull Request on Codecov

84.72% (+0.12%) compared to a994c7b

Details

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a994c7b) 84.60% compared to head (a7b5e5e) 84.72%.
Report is 2 commits behind head on main.

❗ Current head a7b5e5e differs from pull request most recent head c8ba6e8. Consider uploading reports for the commit c8ba6e8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
+ Coverage   84.60%   84.72%   +0.12%     
==========================================
  Files          55       55              
  Lines        5554     5559       +5     
==========================================
+ Hits         4699     4710      +11     
+ Misses        855      849       -6     
Files Coverage Δ
daft/series.py 92.40% <50.00%> (-0.22%) ⬇️
daft/expressions/expressions.py 91.59% <33.33%> (-0.50%) ⬇️

... and 3 files with indirect coverage changes