Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] bugfix when cluster has no workers and key error happens when fetching num cores #1745

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

samster25
Copy link
Member

error in question

virtualenv/lib/python3.8/site-packages/daft/runners/ray_runner.py", line 529, in _run_plan
    cores: int = next(num_cpus_provider) - self.reserved_cores
  File "/tmp/ray/session_2023-12-14_10-43-11_589430_8/runtime_resources/pip/6268584d5ab6509fe9044d782b6939e786ec5677/virtualenv/lib/python3.8/site-packages/daft/runners/ray_runner.py", line 400, in _ray_num_cpus_provider
    last_num_cpus_queried = int(ray.cluster_resources()["CPU"])
KeyError: 'CPU'

@github-actions github-actions bot added the bug Something isn't working label Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #1745 (a64b40c) into main (e4e8528) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1745      +/-   ##
==========================================
- Coverage   85.19%   85.03%   -0.17%     
==========================================
  Files          55       55              
  Lines        5518     5518              
==========================================
- Hits         4701     4692       -9     
- Misses        817      826       +9     
Files Coverage Δ
daft/runners/ray_runner.py 87.79% <100.00%> (-1.18%) ⬇️

... and 2 files with indirect coverage changes

@samster25 samster25 merged commit b2a2bb8 into main Dec 18, 2023
40 checks passed
@samster25 samster25 deleted the sammy/key-error-when-0-cores branch December 18, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant