Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] annotate ray tasks with name of instructions #1729

Merged
merged 2 commits into from
Dec 15, 2023
Merged

[FEAT] annotate ray tasks with name of instructions #1729

merged 2 commits into from
Dec 15, 2023

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Dec 15, 2023 •
edited
Loading

Annotates Ray Tasks with name of instructions
Also adds stage id to TQDM bar to make it more clear that they are separate stages

image

@github-actions github-actions bot added the enhancement New feature or request label Dec 15, 2023
clarkzinzow
clarkzinzow approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@clarkzinzow clarkzinzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice! 🎉

@samster25 samster25 enabled auto-merge (squash) December 15, 2023 00:18
@codecov Codecov
Copy link

codecov bot commented Dec 15, 2023 •
edited
Loading

Codecov Report

Merging #1729 (7bacfbc) into main (52e4809) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1729   +/-   ##
=======================================
  Coverage   85.18%   85.19%           
=======================================
  Files          55       55           
  Lines        5515     5517    +2     
=======================================
+ Hits         4698     4700    +2     
  Misses        817      817
Files Coverage Δ
daft/execution/execution_step.py 93.11% <100.00%> (+0.03%) ⬆️
daft/runners/progress_bar.py 78.84% <100.00%> (ø)
daft/runners/ray_runner.py 88.96% <100.00%> (ø)

@samster25 samster25 merged commit 2d924a1 into main Dec 15, 2023
40 checks passed
@samster25 samster25 deleted the sammy/annotate-ray-tasks branch December 15, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkzinzow clarkzinzow clarkzinzow approved these changes

@jaychia jaychia Awaiting requested review from jaychia

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samster25 @clarkzinzow