-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add smart planning of ScanTasks starting with merging by filesizes #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
+ Coverage 84.89% 85.05% +0.16%
==========================================
Files 55 55
Lines 5349 5354 +5
==========================================
+ Hits 4541 4554 +13
+ Misses 808 800 -8 |
jaychia
force-pushed
the
jay/scan-task-iter
branch
from
December 4, 2023 18:02
ffb59a4
to
8b67cf3
Compare
jaychia
commented
Dec 4, 2023
samster25
reviewed
Dec 4, 2023
samster25
reviewed
Dec 5, 2023
…s globally (#1700) 1. Adds a `daft.context.set_config(**kwargs)` method for users to set configuration parameters in Daft 2. Adds a new `common/daft-config` crate to house the `DaftConfig` struct 3. Thread `PyDaftConfig {config: Arc<DaftConfig>}` through the pyo3 layer for any functions that require access to configuration values: use `daft.context.get_context().daft_config` to retrieve the current `PyDaftConfig` from Python `.set_config()` in action: <img width="1114" alt="image" src="https://github.com/Eventual-Inc/Daft/assets/17691182/95b52ab9-a878-4ec3-abf6-f8950fd8009f"> > NOTE: Because we leverage our current `daft.context` Python global singleton machinery, note that the configs are probably not being propagated correctly in a multiprocessing/Ray worker environment to separate Python processes. > > For this to work, we will need to correctly initialize any Ray workers with the current DaftContext, or abandon the DaftContext machinery for something more suitable. --------- Co-authored-by: Jay Chia <[email protected]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors/changes required on ScanTask itself:
ScanTask::merge
ScanTask::partition_spec()
ScanTask::new
to assert that all the underlying sources have the same partition specI then added a new module
daft_scan::scan_task_iterators
which contains functions that perform transformations on aBox<dyn Iterator<item = DaftResult<ScanTaskRef>>>
.TODO: