Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add warmup step for remote tpch benchmarking #1691

Merged
merged 2 commits into from
Dec 3, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions benchmarking/tpch/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,14 @@ def run_all_benchmarks(
entrypoint=entrypoint,
runtime_env=get_ray_runtime_env(requirements),
)

# Run once as a warmup step
ray_job_runner.run_on_ray(
ray_job_dashboard_url,
{**job_params, "submission_id": job_params["submission_id"] + "-warmup"},
)

# Run second time to collect metrics
with metrics_builder.collect_metrics(i):
ray_job_runner.run_on_ray(
ray_job_dashboard_url,
Expand Down
Loading